Convert createActionManager #723

kebeclibre · 2021-04-12T08:06:00Z

No description provided.

aab-odoo · 2021-04-14T07:37:58Z

addons/web/static/tests/helpers/mock_server.js

what is var?

aab-odoo · 2021-04-14T07:52:36Z

addons/web/static/tests/legacy/control_panel/search_bar_tests.js

it wasn't necessary? you can patchAndCleanup the session I guess

aab-odoo · 2021-04-14T07:54:08Z

addons/web/static/tests/legacy/control_panel/search_bar_tests.js

aab-odoo · 2021-04-14T08:06:40Z

addons/web/static/src/legacy/utils.js

not necessary anymore (?)

aab-odoo · 2021-04-14T08:08:59Z

addons/web/static/tests/helpers/mock_services.js

remove (everywhere as well) ?

aab-odoo · 2021-04-14T08:18:36Z

addons/web/static/tests/legacy/views/form_tests.js

remove ? sorry

aab-odoo

This PR is globally OK, except for the translation part. I'm not sure to understand everything, and I believe it is unnecessary complicated. Let's talk about it tomorrow.

aab-odoo · 2021-04-14T15:49:28Z

addons/web/static/src/legacy/action_adapters.js

Suggested change

// We do want to signal willUnmount to the widget and its children

// without prejudice to exportState's comment.

/**

* The ComponentAdapter calls `on_attach_callback` on `this.widget`. However,

* in the ActionAdapter, we unset `this.widget` (see @exportState) to keep the child

* widget alive when this component is unmounted but the controller is still in the stack.

* This override ensures that `this.widget` is set when willUnmount is called on the

* ComponentAdapter.

*

* @override

*/

aab-odoo · 2021-04-14T16:01:21Z

addons/web/static/src/legacy/utils.js

only used in tests, right? if so, should not be here

aab-odoo · 2021-04-14T16:01:50Z

addons/web/static/src/legacy/legacy_setup.js

legacyTranslationService

aab-odoo · 2021-04-14T16:03:44Z

addons/web/static/src/legacy/utils.js

are we sure that this is patched before being called?

addons/web/static/src/legacy/utils.js

aab-odoo · 2021-04-14T16:07:59Z

addons/web/static/src/localization/translation.js

i'm not sure this really needs to be so complicated

robodoo · 2021-05-20T15:36:52Z

Pull request status dashboard.

robodoo · 2021-05-20T15:36:52Z

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

aab-odoo · 2021-05-25T07:39:55Z

addons/board/static/tests/dashboard_tests.js

no need to destroy (done via registerCleanup in createWebClient)

aab-odoo · 2021-05-25T07:42:13Z

odoo/addons/base/static/tests/base_settings_tests.js

could you try not to prettify all this file?

aab-odoo · 2021-05-26T07:06:53Z

robodoo r+

robodoo · 2021-05-26T07:50:28Z

Linked pull request(s) odoo-dev/enterprise#140 not ready. Linked PRs are not staged until all of them are ready.

robodoo · 2021-05-26T07:50:28Z

Because this PR has multiple commits, I need to know how to merge it:

merge to merge directly, using the PR as merge commit message
rebase-merge to rebase and merge, using the PR as merge commit message
rebase-ff to rebase and fast-forward

kebeclibre · 2021-05-26T07:53:38Z

robodoo rebase-ff

robodoo · 2021-05-26T07:54:02Z

Merge method set to rebase and fast-forward

kebeclibre · 2021-05-26T07:58:46Z

robodoo retry

robodoo · 2021-05-26T07:59:08Z

I'm sorry, @kebeclibre. Retry makes no sense when the PR is not in error.

closes #723 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

kebeclibre force-pushed the master-wowl-staging2-lpe branch 5 times, most recently from b085d50 to 9fc366b Compare April 13, 2021 14:49

aab-odoo reviewed Apr 14, 2021

View reviewed changes

kebeclibre force-pushed the master-wowl-staging2-lpe branch from 8085ebd to 839095b Compare April 14, 2021 13:36

aab-odoo force-pushed the master-wowl branch from 666b481 to 2b2446d Compare April 14, 2021 13:52

kebeclibre force-pushed the master-wowl-staging2-lpe branch from 839095b to d6679fd Compare April 14, 2021 14:13

aab-odoo reviewed Apr 14, 2021

View reviewed changes

aab-odoo force-pushed the master-wowl branch from 281967d to 004cd0d Compare May 3, 2021 09:08

kebeclibre force-pushed the master-wowl-staging2-lpe branch 3 times, most recently from 7ce2048 to 91f3de6 Compare May 14, 2021 08:58

kebeclibre changed the title ~~Master wowl staging2 lpe~~ Convert createActionManager May 14, 2021

aab-odoo force-pushed the master-wowl branch from 4b56c91 to a8ad78e Compare May 17, 2021 09:05

kebeclibre force-pushed the master-wowl-staging2-lpe branch 4 times, most recently from 692e1f5 to 6a0ab41 Compare May 18, 2021 13:14

aab-odoo force-pushed the master-wowl branch from a0c2610 to d6a5cb2 Compare May 18, 2021 14:16

kebeclibre force-pushed the master-wowl-staging2-lpe branch 5 times, most recently from 9dcb549 to f566bac Compare May 20, 2021 11:40

kebeclibre force-pushed the master-wowl-staging2-lpe branch from 804c7dd to d5b301b Compare May 21, 2021 15:39

aab-odoo reviewed May 25, 2021

View reviewed changes

aab-odoo force-pushed the master-wowl branch from bbde66b to 835e649 Compare May 25, 2021 14:09

kebeclibre force-pushed the master-wowl-staging2-lpe branch 4 times, most recently from 5151e20 to 0de8c87 Compare May 26, 2021 06:52

kebeclibre added 2 commits May 26, 2021 09:02

fixup! [REF] web: rewrite webclient in owl

4ebb888

fixup! [REF] *: adapt code to new owl webclient

b818ceb

kebeclibre force-pushed the master-wowl-staging2-lpe branch from 0de8c87 to b818ceb Compare May 26, 2021 07:03

robodoo pushed a commit that referenced this pull request May 26, 2021

fixup! [REF] *: adapt code to new owl webclient

771d72e

closes #723 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

robodoo closed this May 26, 2021

robodoo deployed to merge May 26, 2021 10:02 Active

sdegueldre deleted the master-wowl-staging2-lpe branch May 26, 2021 10:20

-  // We do want to signal willUnmount to the widget and its children
-  // without prejudice to exportState's comment.
+  /**
+   * The ComponentAdapter calls `on_attach_callback` on `this.widget`. However,
+   * in the ActionAdapter, we unset `this.widget` (see @exportState) to keep the child
+   * widget alive when this component is unmounted but the controller is still in the stack.
+   * This override ensures that `this.widget` is set when willUnmount is called on the
+   * ComponentAdapter.
+   *
+   * @override
+   */

Convert createActionManager #723

Convert createActionManager #723

Uh oh!

Conversation

kebeclibre commented Apr 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aab-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robodoo commented May 20, 2021

Uh oh!

robodoo commented May 20, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aab-odoo commented May 26, 2021

Uh oh!

robodoo commented May 26, 2021

Uh oh!

robodoo commented May 26, 2021

Uh oh!

kebeclibre commented May 26, 2021

Uh oh!

robodoo commented May 26, 2021

Uh oh!

kebeclibre commented May 26, 2021

Uh oh!

robodoo commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants